Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configure file used yaml #72

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cnsworder
Copy link

Add configure file used yaml

  • default used ~/.config/.classify.conf file;
  • -c or --config set a config file;

@bhrigu123
Copy link
Owner

bhrigu123 commented Mar 17, 2017

Hey, this is great. Just a few things:

  • Could you handle the exception when the config file given as input has wrong syntax (like missing bracket, comma, etc.), and exit the program? It throws yaml.parser.ParserError.
  • Also, I think it would be great to rename the classify part of the default config file to classifier.
  • And, one question: What was the need to remove check isFile in d99efc8?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants