Skip to content

Comments

Bhumi guides active record basics#3

Open
bhumi1102 wants to merge 61 commits intomainfrom
bhumi-guides-active-record-basics
Open

Bhumi guides active record basics#3
bhumi1102 wants to merge 61 commits intomainfrom
bhumi-guides-active-record-basics

Conversation

@bhumi1102
Copy link
Owner

@bhumi1102 bhumi1102 commented Feb 20, 2024

The Active Record Basics Guide is a manageable size, so not a huge diff. I focused on making the language more friendly, updating code examples and testing all code examples in an app.

Copy link
Collaborator

@Ridhwana Ridhwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome 🎉 I left some feedback and a few suggestions that could be food for thought to hear your preferences.

Copy link
Collaborator

@carlosantoniodasilva carlosantoniodasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates are looking great, other than what's already been reviewed, I had just some minor feedback here and there.

bhumi1102 and others added 10 commits February 28, 2024 08:17
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
bhumi1102 and others added 3 commits February 29, 2024 10:58
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
@bhumi1102
Copy link
Owner Author

Likewise, would it make sense to add an example of generating a model, which gives you the AR model + migration code? Could be a simple bin/rails generate model Book title:string author:string to show how it could generate all that's been showed in section 3, to close it.

Yeah I think that's a useful tip to give the reader. The difference between rails g migration and rails g model. I added it a NOTE at the end of section 3.

@bhumi1102
Copy link
Owner Author

we have an example of how to generate a migration within the guide, but would it be any useful to add one to the migration section itself? Not sure.

I started adding this but then it lead to explaining the references and what that means. I think that's better left to the Migration guide itself, which this section links. I could change the example from Publication to Book for a simpler generate command but felt that using Book again was getting a little repetitive/boring so I left it as is 😅

bhumi1102 and others added 24 commits February 29, 2024 11:50
Co-authored-by: Mina Mikhail <mina@fightingtheboss.com>
Co-authored-by: Guilherme Silva <guilherme.gss@outlook.com.br>
Co-authored-by: Mina Mikhail <mina@fightingtheboss.com>
Co-authored-by: Mina Mikhail <mina@fightingtheboss.com>
Co-authored-by: Bruno Prieto <brunoprietog@hey.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants