Open
Conversation
This reverts commit 9b7d3a8.
Collaborator
carlosantoniodasilva
left a comment
There was a problem hiding this comment.
Looking good @bhumi1102! I had some initial suggestions below.
I know there's probably going to have some back-and-forth as you work through the layouts & rendering, let me know if I can help with anything there.
Ridhwana
reviewed
Mar 22, 2024
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com> Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Collaborator
carlosantoniodasilva
left a comment
There was a problem hiding this comment.
Updates are looking great @bhumi1102! I had just a few minor bits of feedback on a last pass, otherwise this lgtm.
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com> Co-authored-by: Petrik de Heus <petrik@deheus.net> Co-authored-by: Alan Savage <asavageiv@users.noreply.github.com>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Erick Sasse <148989+esasse@users.noreply.github.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action View Overview is ready for review. I'm breaking this bigger task of Action View + Layouts and Rendering guide + new guide into multiple steps. This is step 1. I've gone through Action View Overview top to bottom.
Another PR upcoming for Layout and Rendering guide.
Here are the bullet points from the to-do: