Action View Form Helpers Guide by bhumi1102 · Pull Request #6 · bhumi1102/rails

bhumi1102 · 2024-04-29T17:18:10Z

This one is ready for internal review. It is a bit long but not too bad.

Among other edits and code example updates, I've address the bullet points from the Todo:

Do we still need an HTML5 warning at the end of the 1st section? It's pretty standard these days.
--> agree, removed.
Not sure the output of _form_with model: @article_ is 100% correct, might need to double check that.
--> yes. updated this example and got the HTML output from my "guides playground" rails app.
When we mention record.persisted? in record identification, could be a good plug to link to the Active Model guide on that.
--> Hm...there is no direction mention, other than this https://guides.rubyonrails.org/active_model_basics.html#conversion
Similar to STI, link to the guide / reference on it.
Time Zone and Country Select should likely be broken into separate sub-sections (I don't mind still mentioning country select)
Would the file upload example would be better with a CSV for local processing, rather than showing saving to local disk? (which is probably a very uncommon usage?)
The labeled_form_with example could likely be simplified with _**options_ being all that it takes, instead of explicitly showing all possible kwargs.
It may be better to show "complex forms" (section 10) right after the parameters (section 8), moving "forms to external resources" down... just because complex forms require exactly the fields_for incantation that was detailed further under the parameters section, so it seems a better continuation. (or potentially even reversed? complex forms then params? not sure)
Under "complex forms", adding fields on the flow could be slightly expanded, it feels very "go figure".
--> Yeah, not sure what to do about this one. Was thinking about removing it as there is not built-in support to showcase.

p8

This is looking good. I'm halfway reviewing and hope to continue on friday.

guides/source/form_helpers.md

Ridhwana

This is looking so good @bhumi1102. I've reviewed until line 300, will send the reviews in batches as I work through the whole file.

guides/source/form_helpers.md

Ridhwana

Review until line 618

guides/source/form_helpers.md

p8 · 2024-05-22T12:59:17Z

guides/source/form_helpers.md

 --------------------------------------------------------------------------------

-NOTE: This guide is not intended to be a complete documentation of available form helpers and their arguments. Please visit [the Rails API documentation](https://api.rubyonrails.org/classes/ActionView/Helpers.html) for a complete reference of all available helpers.
+NOTE: This guide is not intended to be a complete list of all available form helpers. Please reference [the Rails API documentation](https://api.rubyonrails.org/classes/ActionView/Helpers.html) for an exhaustive list of form helpers and their arguments.


Also maybe replace exhaustive with the simpler complete?

Suggested change

NOTE: This guide is not intended to be a complete list of all available form helpers. Please reference [the Rails API documentation](https://api.rubyonrails.org/classes/ActionView/Helpers.html) for an exhaustive list of form helpers and their arguments.

NOTE: This guide is not intended to be a complete list of all available form helpers. Please reference [the Rails API documentation](https://api.rubyonrails.org/classes/ActionView/Helpers.html) for a complete list of form helpers and their arguments.

guides/source/form_helpers.md

Co-authored-by: Amanda Perino <58528404+AmandaPerino@users.noreply.github.com> Co-authored-by: Petrik de Heus <petrik@deheus.net>

…s into bhumi-guides-form-helpers

…s natural

Co-authored-by: Karl Lingiah <karl@superchilled.co.uk> Co-authored-by: Petrik de Heus <petrik@deheus.net>

Co-authored-by: Petrik de Heus <petrik@deheus.net>

* Active storage immediate variants (#6) * This commit introduces variant generation strategies for Active Storage, providing more flexible control over when variants are created. - **:lazily** - variants created dynamically when requested (default) - **:later** - variants created in background after attachment - **:immediately** - variants created simultaneously with attachment ```ruby has_one_attached :avatar_with_lazy_variants do |attachable| attachable.variant :lazy_thumb, resize_to_limit: [3, 3], process: :lazy attachable.variant :default_thumb, resize_to_limit: [4, 4] end has_one_attached :avatar_with_later_variants do |attachable| attachable.variant :later_thumb, resize_to_limit: [2, 2], process: :later end has_one_attached :avatar_with_immediate_variants do |attachable| attachable.variant :immediate_thumb, resize_to_limit: [1, 1], process: :immediately end ``` * Active Storage: make Variant#processed? and VariantWithRecord#processed? public Apps can now check whether variants have been generated. Useful for precise control of variant usage or generation. Co-authored-by: Tom Rossi <tomrossi7@users.noreply.github.com> * Deprecate `preprocessed: true` in favor of `process: :later` For removal in Rails 9.0. Co-authored-by: Tom Rossi <tomrossi7@users.noreply.github.com> * Document immediate variants: guide and changelog Co-authored-by: Tom Rossi <tomrossi7@users.noreply.github.com> * Making ActiveStorage::Preview#processed? a public method Removing space * Use consistent naming for transformations parameter (#7) ActiveStorage uses the plural `transformations` for a single hash of transformation options (e.g., `{ resize_to_limit: [100, 100] }`). To differentiate between a single transformation hash and an array of transformation hashes, this commit introduces `transformations_array` for arrays of transformations, while retaining transformations for individual hashes. * Fixing changelog * Rename transformations_array to variants Aligns with `CreateVariantsJob` naming and `ActiveStorage` terminology where variants represent the result of transformations applied to the original blob. Fixing create_preview_image --------- Co-authored-by: Jeremy Daer <jeremy@rubyonrails.org> Co-authored-by: Tom Rossi <tomrossi7@users.noreply.github.com>

bhumi1102 added 23 commits April 29, 2024 12:16

make intro less verbose

b96a271

update first code example

63756d6

update section 1.1

d91ca2e

1.2 checkboxes

7831734

section 1 done

91aae0f

section 2 form_with model object

bb266e9

fields_for

3681ce8

record identification

c066fc7

section 2 done

92c96c6

select boxes

c4262cf

section 3 done

3fe8579

next

df7e678

collection helpers

bc29feb

add a file upload example for csv file upload and processing

0a732b4

clean up

99d4bc4

custom form builders

16dcd25

rename and rearrange sections

86ed35f

input value naming and params hash

d5e53ae

form input naming conventions done

4b2beed

all done expect complex form section

1d36141

complex form

5f21668

remove html5 warning

729a850

more examples in complex form section

42380cb

bhumi1102 changed the title ~~Action View Form Helpers (WIP)~~ Action View Form Helpers Guide May 7, 2024

bhumi1102 requested review from AmandaPerino, Ridhwana and carlosantoniodasilva May 7, 2024 18:15

p8 reviewed May 8, 2024

View reviewed changes

Ridhwana reviewed May 9, 2024

View reviewed changes

Ridhwana reviewed May 10, 2024

View reviewed changes

p8 reviewed May 22, 2024

View reviewed changes

AmandaPerino reviewed May 22, 2024

View reviewed changes