Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Pass dataset-relative paths to .bidsignore checker #1841

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Nov 9, 2023

It looks like ignore wants dataset-relative paths, but we collect them with a leading slash. I'm not sure what the splash damage of removing the leading slash globally is, so instead I'm just dropping it in the ignore check.

Also dropping a vendored ignore package because apparently that's no longer needed.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (288324a) 85.70% compared to head (18e24e3) 85.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
+ Coverage   85.70%   85.97%   +0.27%     
==========================================
  Files         132      131       -1     
  Lines        6714     6268     -446     
  Branches     1555     1527      -28     
==========================================
- Hits         5754     5389     -365     
+ Misses        852      772      -80     
+ Partials      108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator Author

@nellh Are we still doing the build.ts? Or does publishing to deno.land make that irrelevant?

@nellh
Copy link
Member

nellh commented Nov 10, 2023

It's still useful to build for Node targets like the OpenNeuro frontend.

@effigies
Copy link
Collaborator Author

Sounds good. Just spent a bit of time digging to resolve:

Could not resolve "npm:ignore@5.2.4"

    src/files/ignore.ts:2:34:
      2 │ import { default as ignore } from 'npm:ignore@5.2.4'
        ╵                                   ~~~~~~~~~~~~~~~~~~

  You can mark the path "npm:ignore@5.2.4" as external to exclude it from the bundle, which will remove this error.

Was curious if I'd wasted my time. :-)

@effigies effigies merged commit 1192215 into bids-standard:master Nov 30, 2023
26 of 29 checks passed
@effigies effigies deleted the fix/ignores branch November 30, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants