FIX: Add pattern to allow /dir-<label>_dwi.json files
#1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1880 +/- ##
==========================================
- Coverage 85.48% 83.54% -1.94%
==========================================
Files 131 92 -39
Lines 6262 3890 -2372
Branches 1542 1270 -272
==========================================
- Hits 5353 3250 -2103
+ Misses 805 542 -263
+ Partials 104 98 -6 ☔ View full report in Codecov by Sentry. |
|
@rwblair can I get some help on why the test is failing? |
|
The deno tests are always failing, and we're working toward fixing. The node tests are what matters for the legacy (actually current) validator. |
effigies
reviewed
Jan 24, 2024
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
approved these changes
Jan 24, 2024
|
Seems to work locally for our dataset - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, top-level metadata such as
/dir-AP_dwi.jsonare deemed invalid.