Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add top-level phase difference fieldmaps JSONs #1881

Merged

Conversation

oesteban
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (90095d0) 85.48% compared to head (6993e08) 85.47%.

Files Patch % Lines
bids-validator/utils/type.js 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1881      +/-   ##
==========================================
- Coverage   85.48%   85.47%   -0.01%     
==========================================
  Files         131      131              
  Lines        6262     6265       +3     
  Branches     1542     1544       +2     
==========================================
+ Hits         5353     5355       +2     
- Misses        805      806       +1     
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@effigies effigies merged commit 37b8a49 into bids-standard:master Jan 30, 2024
27 of 32 checks passed
@oesteban oesteban deleted the oesteban-patch-top-level-fmaps branch January 30, 2024 14:25
@oesteban
Copy link
Contributor Author

Seems to work locally with our dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants