FIX: Add minimum Python requirement to package metadata #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
+ Coverage 83.57% 85.49% +1.92%
==========================================
Files 92 131 +39
Lines 3890 6262 +2372
Branches 1271 1543 +272
==========================================
+ Hits 3251 5354 +2103
- Misses 541 804 +263
- Partials 98 104 +6 ☔ View full report in Codecov by Sentry. |
|
@rwblair Could we get a patch release whenever it's convenient for you? |
|
Versions 1.14.1-1.14.4 have been yanked from PyPI, so there should be no problems with installation through normal methods now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is the oldest Python that is not EOL, so we only test that far back.
People using older Pythons could still get this installed, and it turns out we
use a Python 3.8 feature.
After the next release, we should yank PyPI packages newer than 1.14.0 so that
Python 3.6 and 3.7 users will install working versions by default.