fix: Preserve key properties when using spread to copy BIDSFile objects in browser environments #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in browser environments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
+ Coverage 83.57% 88.77% +5.20%
==========================================
Files 92 39 -53
Lines 3890 2370 -1520
Branches 1271 272 -999
==========================================
- Hits 3251 2104 -1147
+ Misses 541 260 -281
+ Partials 98 6 -92 ☔ View full report in Codecov by Sentry. |
rwblair
added a commit
to rwblair/legacy-validator
that referenced
this pull request
Apr 19, 2024
fix: Preserve key properties when using spread to copy BIDSFile objects in browser environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1918
These properties defined by getters cannot be copied with the spread operator. Materializing these properties instead matches the Deno behavior and should avoid future differences between the two implementations.