Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HED error reporting and tests #2174

Merged

Fix handling of IssueErrors thrown from hed-validator (second attempt)

a656a9c
Select commit
Loading
Failed to load commit list.
Merged

Fix HED error reporting and tests #2174

Fix handling of IssueErrors thrown from hed-validator (second attempt)
a656a9c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 0s

87.43% (+1.70%) compared to f40d4de

View this Pull Request on Codecov

87.43% (+1.70%) compared to f40d4de

Details

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.43%. Comparing base (f40d4de) to head (a656a9c).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
bids-validator/validators/hed.js 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2174      +/-   ##
==========================================
+ Coverage   85.72%   87.43%   +1.70%     
==========================================
  Files          91      133      +42     
  Lines        3784     7045    +3261     
  Branches     1221     1671     +450     
==========================================
+ Hits         3244     6160    +2916     
- Misses        454      789     +335     
- Partials       86       96      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.