ENH: Add default implementations of File

bids-standard · May 2, 2023 · 8ca4ee7 · 8ca4ee7
1 parent 2e2e95a
commit 8ca4ee7
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/bids_ng/types/api1.py b/bids_ng/types/api1.py
@@ -30,11 +30,16 @@ class File(Protocol[SchemaT]):
     """
 
     path: Path
-    relative_path: Path
     dataset: Optional["BIDSDataset[SchemaT]"]
 
     def __fspath__(self) -> str:
-        ...
+        return str(self.path)
+
+    @property
+    def relative_path(self) -> Path:
+        if self.dataset is None:
+            raise ValueError("No dataset root to construct relative path from")
+        return self.path.relative_to(self.dataset.root)
 
 
 class BIDSFile(File[SchemaT], Protocol):