Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #48

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Some improvements #48

merged 8 commits into from
Jan 22, 2024

Conversation

Fantu
Copy link
Collaborator

@Fantu Fantu commented Jan 22, 2024

  • add github workflow for testing build
    this tests any push and PR building on many systems and different
    configurations for help find regression
  • build: remove include(GNUInstallDirs)
    add of it caused default of CMAKE_INSTALL_SYSCONFDIR to /usr/etc
    default of all paths, if not defined, are present, so I think should be
    ok and better remove it
  • Readme: improve requirements part
  • github: add issues templates for bug report and feature request

this tests any push and PR builing on many system and different
configurations for help find regression
add of it caused default of CMAKE_INSTALL_SYSCONFDIR to /usr/etc
default of all path, if not defined, are present, so I think should be
ok and better remove it
only upstream branches should be tested with this
@bigbigmdm bigbigmdm merged commit 0839260 into bigbigmdm:main Jan 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants