Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_path_style to storage.yml (#5296) #5310

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

Deeptwix
Copy link
Contributor

@Deeptwix Deeptwix commented Jul 6, 2023

Fixes #5296

This variable allows user to use S3 servers configured to have the bucket name in urls in a https://mys3server.com/my-bucket/ fashion rather than being forced to have it in the subdomain.

Adding the setting using an ENV.fetch makes sure that this doesn't brake any existing installation and it preserves the default false value which is probably the correct one for most users.

@farhatahmad
Copy link
Collaborator

Don't forget to add this option to the sample.env so others know it exists

@Deeptwix
Copy link
Contributor Author

Don't forget to add this option to the sample.env so others know it exists

Sorry I missed that, I've updated the branch.
I just added the option, without adding a comment above that explains what it does though, if you feel that this should be done, please let me know.

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@farhatahmad farhatahmad merged commit 5607392 into bigbluebutton:master Jul 11, 2023
3 checks passed
pachidj87 pushed a commit to ZumbTech/Auditorium that referenced this pull request Jul 19, 2023
…on#5310)

* Add force_path_style to storage.yml (bigbluebutton#5296)

* Add force_path_style to sample.env (bigbluebutton#5296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the "force_path_style" option for S3 (active storage)
2 participants