Translate "'s Room" in default room #5313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhatahmad
reviewed
Jul 7, 2023
| @@ -63,7 +63,8 @@ def create_default_room(user) | |||
| return unless user.rooms.count <= 0 | |||
| return unless PermissionsChecker.new(permission_names: 'CreateRoom', user_id: user.id, current_user: user, current_provider:).call | |||
|
|
|||
| Room.create(name: "#{user.name}'s Room", user_id: user.id) | |||
| locale = I18n.default_locale unless valid_locale?(user.language.to_sym) | |||
| Room.create(name: t('room.new_room_name', username: user.name, locale:), user_id: user.id) | |||
There was a problem hiding this comment.
I believe that we can assume the user's language is always valid - why the extra check here?
There was a problem hiding this comment.
I added the check because the tests were failing due to the user's language being set to "language". I don't know whether or not it's possible for a user's language to exist without a corresponding locale file, but if not I can also change the tests to pass a valid language
There was a problem hiding this comment.
Yeah I would update the tests instead
|
Kudos, SonarCloud Quality Gate passed!
|
farhatahmad
approved these changes
Jul 10, 2023
pachidj87
pushed a commit
to ZumbTech/Auditorium
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5255