added user rake task set_admin_role #5587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhatahmad
reviewed
Nov 28, 2023
lib/tasks/user.rake
Outdated
Comment on lines
50
to
67
| if email.blank? | ||
| info 'Please provide an email address of the user you wish to set to Administrator role.' | ||
| else | ||
| user = User.find_by(email:, provider: 'greenlight') | ||
| if user | ||
| role = Role.find_by(name: 'Administrator', provider: 'greenlight') | ||
| if role | ||
| user.role = role | ||
| user.save! | ||
| success "User role set to Administrator for email: #{email}" | ||
| else | ||
| info "Role 'Administrator' not found for provider 'greenlight'" | ||
| end | ||
| else | ||
| info "User with email: #{email} not found" | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
The nested ifs make this super difficult to follow. Might be clearer to use guard clauses here instead
user = User.find_by(email:, provider: 'greenlight')
err 'User with email: #{email} not found' if user.blank?
...
There was a problem hiding this comment.
Yeah that sounds good. I updated the code with the guard clauses so its easier to read!
SilentFlameCR
force-pushed
the
upgrade_user_to_admin_rake
branch
from
b99ccf8
to
919b4a9
Compare
farhatahmad
reviewed
Nov 28, 2023
lib/tasks/user.rake
Outdated
Comment on lines
63
to
64
| user.role = role | ||
| user.save! |
There was a problem hiding this comment.
You can do this in one line user.update(role:)
There was a problem hiding this comment.
got it and updated!
|
Kudos, SonarCloud Quality Gate passed!
|
farhatahmad
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5515