Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop + Eslint + Rspec Clean up #5616

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Rubocop + Eslint + Rspec Clean up #5616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ rules:
max-len:
- 'error'
- code: 150
jsx-a11y/control-has-associated-label: "off"
2 changes: 2 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ require:
- rubocop-performance
- rubocop-rails
- rubocop-rspec
- rubocop-factory_bot
- rubocop-capybara

AllCops:
Exclude:
Expand Down
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ end

group :development do
gem 'rubocop', '~> 1.26', require: false
gem 'rubocop-capybara', '~> 2.19.0', require: false
gem 'rubocop-factory_bot', '~> 2.24.0', require: false
gem 'rubocop-performance', '~> 1.13', require: false
gem 'rubocop-rails', '~> 2.18', '>= 2.18.0', require: false
gem 'rubocop-rspec', '~> 2.9.0', require: false
Expand Down
12 changes: 12 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,10 @@ GEM
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.29.0)
parser (>= 3.2.1.0)
rubocop-capybara (2.19.0)
rubocop (~> 1.41)
rubocop-factory_bot (2.24.0)
rubocop (~> 1.33)
rubocop-performance (1.16.0)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
Expand Down Expand Up @@ -529,6 +533,8 @@ DEPENDENCIES
remote_syslog_logger
rspec-rails (>= 6.0.4)
rubocop (~> 1.26)
rubocop-capybara (~> 2.19.0)
rubocop-factory_bot (~> 2.24.0)
rubocop-performance (~> 1.13)
rubocop-rails (~> 2.18, >= 2.18.0)
rubocop-rspec (~> 2.9.0)
Expand All @@ -539,3 +545,9 @@ DEPENDENCIES
web-console (>= 4.2.1)
webdrivers
webmock

RUBY VERSION
ruby 3.1.0p0

BUNDLED WITH
2.3.9
4 changes: 3 additions & 1 deletion spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@

RSpec.configure do |config|
# Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
config.fixture_path = Rails.root.join('spec/fixtures"')
config.fixture_paths = [
Rails.root.join('spec/fixtures')
]

# If you're not using ActiveRecord, or you'd prefer not to run each of your
# examples within a transaction, remove the following line or assign false
Expand Down
Loading