Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5815 allowed email domains #5919

Merged
merged 14 commits into from
Aug 13, 2024
Merged

5815 allowed email domains #5919

merged 14 commits into from
Aug 13, 2024

Conversation

alihadimazeh
Copy link
Contributor

@alihadimazeh alihadimazeh commented Aug 13, 2024 •
edited
Loading

resolves #5815

alihadimazeh and others added 10 commits August 7, 2024 17:40
@alihadimazeh
Front end changes
681e4be 
- added a row for the specific email domain sign up
- added corresponding locales
@alihadimazeh
Created specific email domain sign up site setting
e3e8778 
- added specific email domain sign up to site settings in `tenant.rb`
@alihadimazeh
Rspec tests and data migration
0c05b7b
@alihadimazeh
external controller tests + rubocop fixes
b10f8c5
@alihadimazeh
rubocop fixes
a6076a6
@alihadimazeh
Rspec test fix for tenants controller spec
1903619 
- added the setting SpecificEmailDomainSignUp
@alihadimazeh
rubocop fix
51f520d
@alihadimazeh
test fixes
ddcc607
@alihadimazeh
Changed Specific Email Domain Sign Up to Allowed Domains
3af318f 
- changed all instances of previous name to AllowedDomains
@alihadimazeh
Delete db/data/20240806205559_add_domain_specific_email_signup_to_sit…
e1d4ed9 
…e_settings.rb
@alihadimazeh alihadimazeh changed the title 5815 signup3 5815 allowed email domains Aug 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
35.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@farhatahmad farhatahmad merged commit 8ea1848 into bigbluebutton:master Aug 13, 2024
2 of 3 checks passed
@hiroshisuga
Copy link
Contributor

hiroshisuga commented Aug 13, 2024 •
edited
Loading

Thanks @alihadimazeh and @farhatahmad !
Just for information, I was using a workaround in the keycloak side:
https://keycloak.discourse.group/t/how-to-restrict-registration-to-specific-email-domains/702/19
And this also works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhatahmad farhatahmad farhatahmad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.0 feature request] Signup only with specific Email domains
3 participants
@alihadimazeh @hiroshisuga @farhatahmad