Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simons refined samples #24

Merged
merged 74 commits into from
May 3, 2024
Merged

add simons refined samples #24

merged 74 commits into from
May 3, 2024

Conversation

Veluchs
Copy link
Contributor

@Veluchs Veluchs commented Apr 24, 2024

does not include the samples which rely on external test data.

does not include the samples which rely on external test data
@terryyz
Copy link
Collaborator

terryyz commented Apr 24, 2024

Hi Simon!

Could you please also add your split to data/raw and run the pytest workflows in your forked repo?

To set up the workflows, you need to enable GitHub Actions in your repo and may replace the script/run.sh with the following content:

NAMES=(chien jenny wenhao niklas hanhu ratna simon)
for name in "${NAMES[@]}"; do
    cp data/raw/*"$name"*py data/clean
done
flake8 data/clean/*.py --select=E9,F63,F7,F82 --show-source --statistics
python script/parse.py

for name in "${NAMES[@]}"; do
    for file in data/processed/*"$name"*wo_doc.py; do

        if ! pytest "$file"; then
            echo "Pytest failed on $file, stopping..."
            exit 1
        fi
    done

    for file in data/processed/*"$name"*w_doc.py; do
        if ! pytest --doctest-modules "$file"; then
            echo "Pytest failed on $file, stopping..."
            exit 1
        fi
    done
done

Cheers

data/clean/f_648_simon.py Outdated Show resolved Hide resolved
@Veluchs
Copy link
Contributor Author

Veluchs commented Apr 25, 2024

Should I add my finalized samples to raw or the initial ones I received?

@terryyz
Copy link
Collaborator

terryyz commented Apr 25, 2024

Should I add my finalized samples to raw or the initial ones I received?

Finalized ones :)

@terryyz terryyz mentioned this pull request May 2, 2024
@Veluchs
Copy link
Contributor Author

Veluchs commented May 2, 2024

Hey,

all test conclude successfully now. Should be ready to merge.

@terryyz
Copy link
Collaborator

terryyz commented May 2, 2024

Hi @Veluchs, could you please resolve your data/processed by updating your repo to the latest version? I also found that you pushed quite a few external data to the repo. Could you also remove them? Thanks!

@Veluchs
Copy link
Contributor Author

Veluchs commented May 3, 2024

Hi @Veluchs, could you please resolve your data/processed by updating your repo to the latest version? I also found that you pushed quite a few external data to the repo. Could you also remove them? Thanks!

Hi @terryyz,
now it should be ready to merge. Removed the external data which I pushed accidentally and also updated to the latest version.

Only the remaining names need to be added to run.sh

@terryyz terryyz merged commit b75ecb0 into bigcode-project:main May 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants