feat: syncs and adds support for button and button-link in site theme#2190
feat: syncs and adds support for button and button-link in site theme#2190hunterbecton wants to merge 1 commit intointegrations/makeswiftfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
d4765d8 to
ce302f8
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-canary-qxq09w3d8-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
migueloller
left a comment
There was a problem hiding this comment.
Looks good! Can we please get a changeset with details on the change, what to expect, what to do to migrate, etc.?
| ${fontTokensToCssVars(fontTokens).join('\n')} | ||
| ${themeToCssVars(theme).join('\n')} | ||
| --font-family-mono: var(--font-family-accent); | ||
| --button-primary-text: var(--button-primary-foreground); |
There was a problem hiding this comment.
We could change all the foreground prop names to text in core/lib/makeswift/components/site-theme/components/button.ts to avoid needing to declare a new --button-primary-text css variable here. We're already building the css variables from the Makeswift control values via themeToCssVars(), so I would prefer to see that functionality not overridden if we can avoid the extra complexity of doing so.
What/Why?
ButtonandButtonLinkwith SoulForegroundtoTextin Site ThemeTesting
CleanShot.2025-04-03.at.14.32.16.mp4