Skip to content

Conversation

@bc-peng
Copy link
Contributor

@bc-peng bc-peng commented Dec 9, 2025

What/Why?

Handle errors when applying a coupon or gift certificate.

Rollout/Rollback

Revert.

Testing

When a coupon is invalid

Screen.Recording.2025-12-09.at.16.16.38.mov

When maximum coupon usage reached

Screen.Recording.2025-12-09.at.16.22.15.mov

@bc-peng bc-peng requested a review from a team as a code owner December 9, 2025 05:25
@bc-peng bc-peng changed the title Checkout 9679 feat(checkout): CHECKOUT-9679 Handle Coupon Error Dec 9, 2025
Comment on lines +35 to +37
if (error instanceof Error) {
setCouponError(error.message);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just relay the error message from the API here.
If it is not a standard error, then it will escalate to the ErrorBoundries and go to Sentry eventually.

@bc-peng bc-peng merged commit 345a965 into master Dec 10, 2025
9 checks passed
@bc-peng bc-peng deleted the CHECKOUT-9679 branch December 10, 2025 23:14
@bc-launchbay
Copy link

checkout-js deployed to Integration US
success 20251210232824 by Launchbay

@bc-launchbay
Copy link

checkout-js deployed to Staging US
success 20251210232824 by Launchbay

@github-actions
Copy link

⚡️ Lighthouse results

🖥️ Desktop:

Category Score
🟠 Performance 88
🟢 Accessibility 91
🟠 Best practices 78

📱 Mobile:

Category Score
🟠 Performance 59
🟢 Accessibility 90
🟠 Best practices 78

@bc-launchbay
Copy link

checkout-js deployed to Production US
success 20251210232824 by Launchbay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants