Merge pull request #6 from bigcommerce/php84

chore(platform): PHPMNT-177 Add PHP 8.4 to CircleCI test matrix
bigcommerce · Dec 29, 2024 · 1c9ded4 · 1c9ded4
2 parents f56314f + edda41e
commit 1c9ded4
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -11,7 +11,7 @@ workflows:
       - php/phpunit-tests:
           matrix:
             parameters:
-              php-version: [ "8.0", "8.1", "8.2", "8.3" ]
+              php-version: [ "8.0", "8.1", "8.2", "8.3", "8.4" ]
       - php/composer-github:
           filters:
             tags:

diff --git a/src/Dflydev/Hawk/Header/Header.php b/src/Dflydev/Hawk/Header/Header.php
@@ -8,7 +8,7 @@ class Header
     private $fieldValue;
     private $attributes;
 
-    public function __construct($fieldName, $fieldValue, array $attributes = null)
+    public function __construct($fieldName, $fieldValue, ?array $attributes = null)
     {
         $this->fieldName = $fieldName;
         $this->fieldValue = $fieldValue;
@@ -25,7 +25,7 @@ public function fieldValue()
         return $this->fieldValue;
     }
 
-    public function attributes(array $keys = null)
+    public function attributes(?array $keys = null)
     {
         if (null === $keys) {
             return $this->attributes;

diff --git a/src/Dflydev/Hawk/Header/HeaderFactory.php b/src/Dflydev/Hawk/Header/HeaderFactory.php
@@ -4,7 +4,7 @@
 
 class HeaderFactory
 {
-    public static function create($fieldName, array $attributes = null)
+    public static function create($fieldName, ?array $attributes = null)
     {
         $fieldValue = 'Hawk';
 
@@ -22,7 +22,7 @@ public static function create($fieldName, array $attributes = null)
         return new Header($fieldName, $fieldValue, $attributes);
     }
 
-    public static function createFromString($fieldName, $fieldValue, array $requiredKeys = null)
+    public static function createFromString($fieldName, $fieldValue, ?array $requiredKeys = null)
     {
         return static::create(
             $fieldName,

diff --git a/src/Dflydev/Hawk/Header/HeaderParser.php b/src/Dflydev/Hawk/Header/HeaderParser.php
@@ -4,7 +4,7 @@
 
 class HeaderParser
 {
-    public static function parseFieldValue($fieldValue, array $requiredKeys = null)
+    public static function parseFieldValue($fieldValue, ?array $requiredKeys = null)
     {
         if (!str_starts_with($fieldValue, 'Hawk')) {
             throw new NotHawkAuthorizationException;

diff --git a/src/Dflydev/Hawk/Server/UnauthorizedException.php b/src/Dflydev/Hawk/Server/UnauthorizedException.php
@@ -9,7 +9,7 @@ class UnauthorizedException extends \Exception
     private $attributes;
     private $header;
 
-    public function __construct($message = null, array $attributes = null)
+    public function __construct($message = null, ?array $attributes = null)
     {
         parent::__construct($message);
         $this->attributes = $attributes ?: array();