Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STRF-11900 Bump paper and handlebars for node 20 #1219

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Aug 13, 2024

What?

  • Update CI for windows-latest
  • Update nvmrc
  • Bump paper and paper-handleabrs

Tickets / Documentation

Screenshots (if appropriate)

Screenshot 2024-08-20 at 17 44 12 Screenshot 2024-08-20 at 17 44 49

cc @bigcommerce/storefront-team

@jairo-bc jairo-bc changed the title feat: STRF-11900 Support windows latest on node 22 feat: STRF-11900 Bump paper and handlebars for node 20 Aug 20, 2024
@jairo-bc jairo-bc marked this pull request as ready for review August 20, 2024 15:44
@jairo-bc jairo-bc requested a review from a team August 20, 2024 17:32
Copy link
Contributor

@jmwiese jmwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jordanarldt jordanarldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything works well on node 20 using this branch 💚

image

@jairo-bc jairo-bc merged commit 72758ef into master Aug 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants