The span does not appear to be within the h2 tag and the extract removes the h2 tag from the tree #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2 tag from the tree
|
Hey @taz77 heads up that an updated version of civic-scraper (0.2.10) is now on PyPI. Had to create a new PR (#190) to handle this and an unrelated issue, along with with misc headaches related to our build process. Closing this now in favor of #190, but shout back on #176 if you're still finding bugs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issues in #91 and #176
Tested this change via debugger and the committee names are now being returned like they were before. I do not know the root cause for why this broke or why this worked before. I spot checked several municipalities websites in the google doc and they were all this way where the span is not in the h2 tag.