fix: resolve inter-fragment ref dependencies in object type building#12
Open
trezy wants to merge 1 commit intobigmoves:mainfrom
Open
fix: resolve inter-fragment ref dependencies in object type building#12trezy wants to merge 1 commit intobigmoves:mainfrom
trezy wants to merge 1 commit intobigmoves:mainfrom
Conversation
Fragment refs (e.g., defs#release and defs#releaseDate) were built in a single pass sorted alphabetically. When one fragment depended on another that came later alphabetically, the ref lookup failed and fell back to [String!]. Use multiple passes so types built in earlier passes are available for subsequent ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defs#releaseanddefs#releaseDate) were built in a single pass sorted alphabetically. When one fragment depended on another that came later alphabetically, the ref lookup failed and fell back to[String!]instead of the correct object type.Test plan
gleam test)defsfile containing two object types where one references the other via an array of refs (e.g.,parentwithchildren: { type: "array", items: { type: "ref", ref: "com.example.defs#child" } }andchildwith string properties). The dependent type must sort alphabetically before its dependency (e.g.,parentbeforeparentDetail). Query the nested field with a selection set and confirm it resolves to the object type rather than erroring withtype "[String!]" has no subfields.