Open
Conversation
bignimbus
reviewed
Feb 10, 2020
Owner
bignimbus
left a comment
bignimbus
left a comment
There was a problem hiding this comment.
This seems like a good feature to have. It would be nice to add options for the new CLI as well (just merged).
| pathToImport = this.aliases[aliasKeys[index]]; | ||
| } else { | ||
| pathToImport = capture; | ||
| if(this.ignorePaths.indexOf(capture) === -1 && (!this.ignorePathPattern || !this.ignorePathPattern.test(capture))) { |
Owner
There was a problem hiding this comment.
What do you think about inverting the base case here?
var isIgnored = this.ignorePaths.indexOf(capture) !== -1;
var isPatternIgnored = this.ignorePathPattern && this.ignorePathPattern.test(capture)
if (isIgnored || isPatternIgnored) {
return m;
}
// ...To the reader, adding another nesting level makes this method seem more complicated than it actually is with these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because I have some import statements that resolve to files contained in a peer dependant node module, I needed the ability to specify certain paths that the resolver would ignore, leaving the import statements intact.
I've implemented the two options for achieving this that I figured would be most useful to people.