Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Support semicolon-separated lists in Performer fields #141

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

sellth
Copy link
Collaborator

@sellth sellth commented Feb 1, 2024

Note: This would be another CUBI deviation from the ISA standard.

  • modify model
  •  adapt parser
  • adapt writer
  • adapt tests
  • documentation

closes #140

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58aa5d0) 96.52% compared to head (643ecfe) 96.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files          29       29           
  Lines        3426     3426           
=======================================
  Hits         3307     3307           
  Misses        119      119           
Flag Coverage Δ
python 96.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sellth sellth marked this pull request as ready for review February 1, 2024 18:35
@sellth sellth changed the title feat: Add list processing for Performer fields feat!: Add list processing for Performer fields Feb 1, 2024
@sellth sellth changed the title feat!: Add list processing for Performer fields feat!: Support semicolon-separated lists in Performer fields Feb 2, 2024
@holtgrewe holtgrewe merged commit ef8668c into master Feb 5, 2024
11 checks passed
@holtgrewe holtgrewe deleted the performer_lists branch February 5, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add list processing for Performer fields
2 participants