Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow bwa_mem2 and mbcs in cbioportal_export model #603

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

tedil
Copy link
Member

@tedil tedil commented Feb 5, 2025

Fixes #600

@tedil tedil requested a review from ericblanc20 February 5, 2025 11:37
@coveralls
Copy link

coveralls commented Feb 5, 2025

Coverage Status

coverage: 85.811% (+0.003%) from 85.808%
when pulling efc4bc3 on update-cbioportal-export-model
into f49fafb on main.

@tedil tedil requested a review from mbenary February 5, 2025 11:53
Copy link
Contributor

@ericblanc20 ericblanc20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One thing though:
STAR should not be added to the mapping tools, because cbioportal handles expression data very differently than genetic data.

@tedil
Copy link
Member Author

tedil commented Feb 5, 2025

Thanks! One thing though: STAR should not be added to the mapping tools, because cbioportal handles expression data very differently than genetic data.

Thank you, fixed that!

@tedil tedil requested a review from ericblanc20 February 5, 2025 15:02
@ericblanc20 ericblanc20 merged commit 882e869 into main Feb 5, 2025
5 checks passed
@ericblanc20 ericblanc20 deleted the update-cbioportal-export-model branch February 5, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydantic model for cbioportal_export incomplete
3 participants