server: Load and dispatch login/default collection/keyring #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the prompt review and I'm sorry for the late response from my side :) |
warusadura
force-pushed
the
login
branch
2 times, most recently
from
09d26c7 to
7ff8bfe
Compare
warusadura
force-pushed
the
login
branch
4 times, most recently
from
0049157 to
ae3d5a6
Compare
|
Also you have access to this repo, use a branch in it to make it easier for me to push quick fixes :) |
That generates and returns a random Secret. Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
Yeah, thanks! But I kinda like this way, I'm learning a lot of Rust from you :) |
|
Looks good, just squash the last 3 server related commits as they are not clean by themselves and there is little benefit in cleaning them up. Maybe re-change the commit message to "server: Create a keyring when dispatching default/login collections" |
Also add the following changes: Add Error. Load a temporary keyring when dispatching the session collection. Add --login command line option. Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
|
Done. |
bilelmoussaoui
approved these changes
Oct 24, 2024
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load temporary keyring when dispatching the session collection. Since the session collection is never stored to the disk, loading a temporary keyring is enough.
This change loads and dispatches the login/default collection/keyring into the object tree. This change also adds,
--logincommand line option to oo7-daemon.-l, --loginoption will read a password from stdin, and use it to unlock the login keyring.