server: Add GetSecret, GetSecrets and SetSecret implementation #153
Conversation
warusadura
changed the title
warusadura
changed the title
warusadura
changed the title
warusadura
force-pushed
the
secret
branch
2 times, most recently
from
8784f6d to
b118363
Compare
warusadura
force-pushed
the
secret
branch
4 times, most recently
from
52d38b1 to
65d63ec
Compare
| let mut secrets = HashMap::new(); | ||
| let collections = self.collections.lock().await; | ||
|
|
||
| 'outer: for collection in collections.iter() { |
There was a problem hiding this comment.
Aren't the items paths have the collection in their path? so can we use that to figure out the corresponding collections of each item or?
There was a problem hiding this comment.
Why though :) is it bad practice to use a labeled loop block?
There was a problem hiding this comment.
Nothing per see, just trying to understand what is the most efficient way to do all of this.
warusadura
force-pushed
the
secret
branch
2 times, most recently
from
4b46726 to
ed96e28
Compare
warusadura
changed the title
| let mut secrets = HashMap::new(); | ||
| let collections = self.collections.lock().await; | ||
|
|
||
| 'outer: for collection in collections.iter() { |
There was a problem hiding this comment.
Nothing per see, just trying to understand what is the most efficient way to do all of this.
|
The commit message and it description could use some work, in general. Currently you just duplicate the commit message "title" with the "description". In the description, add any technical information or detail or leave it empty. |
Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
This change adds Secret Service method GetSecrets and Secret Item methods GetSecret and SetSecret.