Add a portal implementation #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A6GibKm
force-pushed
the
portal-backend
branch
3 times, most recently
from
7e128dd to
d457d09
Compare
A6GibKm
force-pushed
the
portal-backend
branch
2 times, most recently
from
58572b4 to
140930d
Compare
A6GibKm
force-pushed
the
portal-backend
branch
2 times, most recently
from
74ee254 to
8d296e7
Compare
ueno
reviewed
Dec 20, 2023
oo7-portal-impl/src/main.rs
Outdated
| attributes, | ||
| &secret, | ||
| true, | ||
| // TODO Find a better one. |
There was a problem hiding this comment.
is this what the current portal implementation doing?
bilelmoussaoui
force-pushed
the
portal-backend
branch
2 times, most recently
from
eab6845 to
e40adc6
Compare
bilelmoussaoui
force-pushed
the
portal-backend
branch
from
e40adc6 to
6ad53ed
Compare
This is something we can do later imho |
A6GibKm
force-pushed
the
portal-backend
branch
3 times, most recently
from
ed2745b to
8e77eed
Compare
A6GibKm
force-pushed
the
portal-backend
branch
4 times, most recently
from
15e46a9 to
de47f50
Compare
bilelmoussaoui
force-pushed
the
portal-backend
branch
2 times, most recently
from
b85d9c1 to
9fba035
Compare
bilelmoussaoui
changed the title
bilelmoussaoui
force-pushed
the
portal-backend
branch
2 times, most recently
from
b914433 to
8291639
Compare
Currently it still lacks: - Proper end-to-end tests on the CI using the support we have for the portal from the client side as well but that requires a mock server which we don't have an implementation for yet - Build system integration so that the necessary file for the binary to be picked up as a secret portal provider can be installed
bilelmoussaoui
force-pushed
the
portal-backend
branch
from
8291639 to
0c74098
Compare
|
From my point of view, the only thing missing here is more testing. |
|
We can have more testing once we get the server bits re-implemented. Then we can write a mock implementation and have all the bits tested. For now, let us land it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things missing
Requestdoing the correct thing?This is compatible with gnome-keyring's stored secrets, but we store them with a more descriptive label, e.g.
See flatpak/xdg-desktop-portal#482.