-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New gnome keyring #73
base: main
Are you sure you want to change the base?
Conversation
31b6649
to
758f4be
Compare
Does it make sense to store the
and then, store the same session inside Collection,
with this way we get access to all the available sessions and we can retrieve a session based on an objectpath. wdyt? |
Storing the session is required yes, but not just it ObjectPath. Instead you need to store the Sesssion itself which would contain more information than just the object path. Ideally we can store it as |
b23a796
to
2ab4b4b
Compare
1f012ae
to
b1df587
Compare
Since Collection is not using and cannot be implemented (easily) Copy or Clone traits, the only way to clone a struct Collection is call Collection::new() passing getter values. Removed set_collections() setter. See: #73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
b1df587
to
9163fa1
Compare
e149b7c
to
7d584ae
Compare
95ebf46
to
d3d7410
Compare
01d1fa7
to
dd9a71a
Compare
Removed RwLock wrapper from sessions Removed async from all the methods See: #73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
989307f
to
1ea5e4e
Compare
69c5d72
to
9a7f106
Compare
f13ba12
to
324e44e
Compare
Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
324e44e
to
64a5c25
Compare
Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
64a5c25
to
db054ee
Compare
Also updated the getter. Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
According to the previous change/commit. Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
… storage Perform a decryption operation for the transit data (from client) before creating a new item based on the data/arguments. Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
And introduces encrypting item data before transit to the client side. Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
db054ee
to
3438259
Compare
Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
3438259
to
432f76f
Compare
This change fixes the SetSecret call failing to correctly update the secret of an item. Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
c0dfab7
to
9c44ad2
Compare
Since Collection is not using and cannot be implemented (easily) Copy or Clone traits, the only way to clone a struct Collection is call Collection::new() passing getter values. Removed set_collections() setter. See: #73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
Removed RwLock wrapper from sessions Removed async from all the methods See: #73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
9c44ad2
to
134f0ed
Compare
Since Collection is not using and cannot be implemented (easily) Copy or Clone traits, the only way to clone a struct Collection is call Collection::new() passing getter values. Removed set_collections() setter. See: bilelmoussaoui#73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
Removed RwLock wrapper from sessions Removed async from all the methods See: bilelmoussaoui#73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
Since Collection is not using and cannot be implemented (easily) Copy or Clone traits, the only way to clone a struct Collection is call Collection::new() passing getter values. Removed set_collections() setter. See: bilelmoussaoui#73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
Removed RwLock wrapper from sessions Removed async from all the methods See: bilelmoussaoui#73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
134f0ed
to
0f4275b
Compare
Do you think you can rebase this one so we can see what is still left in the PR that has not landed / worked on yet? |
Since Collection is not using and cannot be implemented (easily) Copy or Clone traits, the only way to clone a struct Collection is call Collection::new() passing getter values. Removed set_collections() setter. See: #73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
Removed RwLock wrapper from sessions Removed async from all the methods See: #73 (comment) Signed-off-by: Dhanuka Warusadura <dhanuka@gnome.org>
Switches #56 to use a branch from this repo so we can easily collaborate on it.
progress to-date: