Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure icon and mouse themes are also applied for GTK-3 and GTK-4, ensure Qt and Qt icon themes update #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mvidaldp
Copy link

@mvidaldp mvidaldp commented Dec 5, 2023

No description provided.

@mvidaldp mvidaldp changed the title Ensure icon and mouse themes are also applied for GTK-2, GTK-3 and GTK-4 Ensure icon and mouse themes are also applied for GTK-3 and GTK-4, ensure Qt and Qt icon themes update Dec 11, 2023
@Saijin-Naib
Copy link

Saijin-Naib commented Jan 14, 2024

This is absolutely amazing!

Edit:
I undersold how nice a user experience this is! Finally, finally, (practically) every type of app plays nice and changes light/dark along with my XFCE/XAPP stuff.

@mvidaldp
Copy link
Author

This is absolutely amazing!

Edit: I undersold how nice a user experience this is! Finally, finally, (practically) every type of app plays nice and changes light/dark along with my XFCE/XAPP stuff.

Thanks a lot for your nice words @Saijin-Naib :)
Could you tell me which type of app is not changing light/dark properly?

@Saijin-Naib
Copy link

Currently, Flatpak'd GTK Apps wont change alongside my regular installed apps.

@Saijin-Naib
Copy link

This is absolutely amazing!
Edit: I undersold how nice a user experience this is! Finally, finally, (practically) every type of app plays nice and changes light/dark along with my XFCE/XAPP stuff.

Thanks a lot for your nice words @Saijin-Naib :) Could you tell me which type of app is not changing light/dark properly?

Distro-packaged Fractal and GNOME Builder, so I guess GTK4/libadwaita apps are not behaving now.

@mvidaldp
Copy link
Author

This is absolutely amazing!
Edit: I undersold how nice a user experience this is! Finally, finally, (practically) every type of app plays nice and changes light/dark along with my XFCE/XAPP stuff.

Thanks a lot for your nice words @Saijin-Naib :) Could you tell me which type of app is not changing light/dark properly?

Distro-packaged Fractal and GNOME Builder, so I guess GTK4/libadwaita apps are not behaving now.

It will work if you use aur/libadwaita-without-adwaita-git instead of the default libadwaita (GTK4) :)

@Saijin-Naib
Copy link

It will work if you use aur/libadwaita-without-adwaita-git instead of the default libadwaita (GTK4) :)

Ah, that is not currently packaged for Alpine.

Is it not possible with the default Adwaita/libadwaita?

@mvidaldp
Copy link
Author

mvidaldp commented Apr 4, 2024

It will work if you use aur/libadwaita-without-adwaita-git instead of the default libadwaita (GTK4) :)

Ah, that is not currently packaged for Alpine.

Is it not possible with the default Adwaita/libadwaita?

I don't think so. A bug/feature is preventing this on default gtk4 libadwaita.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants