fix: implement missing skip-monthly/daily logic in futures markPrice script#446
Open
xdifu wants to merge 1 commit intobinance:masterfrom
Open
fix: implement missing skip-monthly/daily logic in futures markPrice script#446xdifu wants to merge 1 commit intobinance:masterfrom
xdifu wants to merge 1 commit intobinance:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a long-standing bug introduced in commit
df27179(May 2022) wherepython/download-futures-markPriceKlines.pyignored the-skip-monthlyand-skip-dailyarguments.Unlike
download-kline.py, this script was unconditionally downloading data types even when explicitly asked to skip them. This PR aligns the behavior of the mark price script with the rest of the codebase.Changes
download_monthly_markPriceKlinescall withif args.skip_monthly == 0:.download_daily_markPriceKlinescall withif args.skip_daily == 0:.Verification
-skip-daily 1now correctly skips the daily download phase.-skip-monthly 1now correctly skips the monthly download phase.Related Issue
Closes #445