Fix NullPointerException in WxOpenXmlMessage.fromEncryptedXml method #3708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WxOpenXmlMessage.fromEncryptedXml()
method was vulnerable toNullPointerException
when processing encrypted WeChat Open Platform messages, particularly affectingreceive_ticket
functionality that worked in 4.7.6.B but failed in 4.7.7.B.Root Cause Analysis
The issue occurred in two scenarios:
fromXml()
method: If the decrypted XML content was null, callingxml.replace("</PicList><PicList>", "")
would throwNullPointerException
fromEncryptedXml()
method: No validation was performed on the decrypted content before passing it tofromXml()
Changes Made
Added null safety to
fromXml()
method:Added validation and error handling to
fromEncryptedXml()
:Benefits
NullPointerException
when processing encrypted messagesThe fix is minimal and surgical, addressing only the error-prone code paths while maintaining all existing functionality.
Fixes #3700.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.