Skip to content

Chore | Update hcl parsing library #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelofenoglio merged 4 commits into from
Aug 11, 2025
Merged

Chore | Update hcl parsing library #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c058a41
Upgrade python-hcl2 library
angelofenoglio Jul 29, 2025
69f5c6a
Update lock file
angelofenoglio Jul 29, 2025
8aa0da6
Fix integration test workflows
angelofenoglio Jul 29, 2025
659f108
Drop tofu image for now
angelofenoglio Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
max-parallel: 1
matrix:
python-version: ['3.9.15', '3.10.8', '3.11.8', '3.12.7']
toolbox-image-tag: ['1.3.5-0.2.0', '1.5.0-0.2.0', '1.6.0-0.2.0']
toolbox-image-tag: ['1.3.5-0.2.3', '1.5.0-0.2.3', '1.6.0-0.2.3']
steps:
- name: Checkout base branch
uses: actions/checkout@v3
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
printf "[INFO] Testing terraform\n"

printf "[INFO] Initializing layer\n"
leverage tf init --skip-validation
leverage terraform init --skip-validation
Copy link
Collaborator

@diego-ojeda-binbash diego-ojeda-binbash Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelofenoglio Shouldn't we use tofu instead of terraform here?

Copy link
Contributor Author

@angelofenoglio angelofenoglio Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to deprecate all currently tested images, (see L29 on this file).
It would require a little more refactoring here that I want to tackle in a later PR

Copy link
Contributor Author

@angelofenoglio angelofenoglio Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or rather go with some conditional logic or something of the sort.


working-directory: ../theadamproject/security/us-east-1/base-tf-backend

Expand Down
Loading
Loading