Fix for handling positional parameter expansion #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, sh_expand fails to expand positional parameters in PaSh because the additional type annotation that PaSh expects is missing from the expansion of the positional parameters.
Positional parameters are heavily used in newer benchmarks specifically, and it enables changing the inputs to the script through the command line directly instead of manually modifying scripts.
When positional parameters are present in the script, PaSh silently reverts to sequential shell execution, making it seem like it fails to accelerate computation when it may actually be able to accelerate. This change would also positively impact the user experience for PaSh overall.