Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up tests using crash test biobox #113

Open
wants to merge 4 commits into
base: version/0.6.1
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch to crash test biobox in feature tests
michaelbarton committed May 7, 2017
commit f625cd4aeb8e8825d309b746fc39e17e375d0000
15 changes: 9 additions & 6 deletions features/biobox.feature
Original file line number Diff line number Diff line change
@@ -56,7 +56,8 @@ Feature: A CLI to run biobox-compatible Docker containers
biobox \
run \
short_read_assembler \
bioboxes/velvet \
bioboxes/crash-test-biobox \
--task=short-read-assembler \
--no-rm \
--input=$(realpath reads.fq.gz) \
--output=$(realpath .)/contigs.fa
@@ -77,7 +78,8 @@ Feature: A CLI to run biobox-compatible Docker containers
biobox \
run \
short_read_assembler \
<assembler> \
bioboxes/crash-test-biobox \
--task=short-read-assembler \
<resources> \
--no-rm \
--input=reads.fq.gz \
@@ -90,9 +92,9 @@ Feature: A CLI to run biobox-compatible Docker containers
And the file "contigs.fa" should not be empty

Examples:
| assembler | resources |
| bioboxes/velvet | --memory=1g |
| bioboxes/velvet | --cpu-shares=512 |
| resources |
| --memory=1g |
| --cpu-shares=512 |


Scenario Outline: Running a biobox assembler benchmark container
@@ -109,9 +111,10 @@ Feature: A CLI to run biobox-compatible Docker containers
biobox \
run \
assembler_benchmark \
bioboxes/quast \
bioboxes/crash-test-biobox \
<resources> \
--no-rm \
--task=quast \
--input-fasta=input/assembly.fasta \
--output=output
"""
2 changes: 1 addition & 1 deletion features/login.feature
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ Feature: Allow a user to ssh into an image to test internally
Scenario: Logging into an image and listing file locations
When I run the interactive command:
"""
biobox login short_read_assembler bioboxes/velvet
biobox login short_read_assembler bioboxes/crash-test-biobox
"""
And I type:
"""
4 changes: 2 additions & 2 deletions features/user_errors.feature
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ Feature: Providing useful errors to a user when they run the tool incorrectly
Scenario Outline: Trying to run an unknown command
When I run the command:
"""
biobox <cmd> short_read_assembler bioboxes/velvet --help
biobox <cmd> short_read_assembler bioboxes/crash-test-biobox --help
"""
Then the stdout should be empty
And the exit code should be 1
@@ -23,7 +23,7 @@ Feature: Providing useful errors to a user when they run the tool incorrectly
Scenario Outline: Trying to use an unknown biobox type
When I run the command:
"""
biobox <command> unknown bioboxes/velvet
biobox <command> unknown bioboxes/crash-test-biobox
"""
Then the stdout should be empty
And the exit code should be 1
12 changes: 6 additions & 6 deletions features/verify.feature
Original file line number Diff line number Diff line change
@@ -3,26 +3,26 @@ Feature: A CLI to verify images are biobox-compatible
Scenario Outline: Verifying a valid biobox image
When I run the command:
"""
biobox verify <type> <image> <args>
biobox verify <type> bioboxes/crash-test-biobox --task=<task>
"""
Then the stdout should be empty
And the stderr should be empty
And the exit code should be 0

Examples:
| type | image | args |
| short_read_assembler | bioboxes/velvet | --task=default |
| assembler_benchmark | bioboxes/quast | |
| type | task |
| short_read_assembler | short-read-assembler |
| assembler_benchmark | quast |


Scenario: Generating a verbose output of biobox image verification
When I run the command:
"""
biobox verify \
short_read_assembler \
bioboxes/velvet \
bioboxes/crash-test-biobox \
--verbose \
--t default
--t short-read-assembler
"""
Then the stderr should be empty
And the stdout should equal: