Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastx_toolkit: add linux-aarch64 build #53667

Merged
merged 17 commits into from
Feb 4, 2025

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Feb 3, 2025

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g added the aarch64 Related to adding linux-aarch64 support label Feb 3, 2025
@martin-g
Copy link
Contributor Author

martin-g commented Feb 4, 2025

Thank you, @mencian !

@martin-g
Copy link
Contributor Author

martin-g commented Feb 4, 2025

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 fastx_toolkit-0.0.14-h503566f_13.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
osx-64 fastx_toolkit-0.0.14-h5eaf441_13.tar.bz2 osx-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>
linux-aarch64 fastx_toolkit-0.0.14-h80f0ee0_13.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/7829b3a9-9361-48a2-b875-6eee50ef2464/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
fastx_toolkit 0.0.14--h503566f_13 GitHub Actions
showImages are in the linux-64 zip file above.gzip -dc images/fastx_toolkit---0.0.14--h503566f_13.tar.gz | docker load

@martin-g
Copy link
Contributor Author

martin-g commented Feb 4, 2025


mgrigorov in 🌐 euler-arm-22 in /tmp/fastx_toolkit took 2s 
❯ tar xvf fastx_toolkit-0.0.14-h80f0ee0_13.tar.bz2 
info/run_exports.json
info/test/run_test.sh
info/hash_input.json
info/index.json
info/recipe/fastx-toolkit-gcc7.patch
info/files
info/recipe/build.sh
info/recipe/fastx.patch
info/recipe/meta.yaml.template
info/recipe/meta.yaml
info/paths.json
info/recipe/conda_build_config.yaml
info/about.json
info/licenses/COPYING
info/git
bin/fastq_quality_boxplot_graph.sh
bin/fastx_nucleotide_distribution_graph.sh
bin/fastx_nucleotide_distribution_line_graph.sh
bin/fastq_quality_converter
bin/fastx_reverse_complement
bin/fastx_artifacts_filter
bin/fastq_to_fasta
bin/fasta_nucleotide_changer
bin/fastx_renamer
bin/fastq_quality_trimmer
bin/fastq_masker
bin/fastx_trimmer
bin/fastq_quality_filter
bin/fastx_quality_stats
bin/fasta_formatter
bin/fastx_uncollapser
bin/fastx_collapser
bin/fastx_clipper
share/aclocal/ax_c_long_long.m4
share/aclocal/ax_cxx_header_stdcxx_tr1.m4
share/aclocal/ax_cxx_compile_stdcxx_11.m4
bin/fasta_clipping_histogram.pl
bin/fastx_barcode_splitter.pl

mgrigorov in 🌐 euler-arm-22 in /tmp/fastx_toolkit 
❯ file ./bin/*
./bin/fasta_clipping_histogram.pl:                 Perl script text executable
./bin/fasta_formatter:                             ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fasta_nucleotide_changer:                    ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastq_masker:                                ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastq_quality_boxplot_graph.sh:              Bourne-Again shell script, ASCII text executable
./bin/fastq_quality_converter:                     ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastq_quality_filter:                        ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastq_quality_trimmer:                       ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastq_to_fasta:                              ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastx_artifacts_filter:                      ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastx_barcode_splitter.pl:                   Perl script text executable
./bin/fastx_clipper:                               ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastx_collapser:                             ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastx_nucleotide_distribution_graph.sh:      Bourne-Again shell script, ASCII text executable
./bin/fastx_nucleotide_distribution_line_graph.sh: Bourne-Again shell script, ASCII text executable
./bin/fastx_quality_stats:                         ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastx_renamer:                               ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastx_reverse_complement:                    ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastx_trimmer:                               ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped
./bin/fastx_uncollapser:                           ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped

mgrigorov in 🌐 euler-arm-22 in /tmp/fastx_toolkit 
❯ ./bin/fasta_formatter -h
usage: fasta_formatter [-h] [-i INFILE] [-o OUTFILE] [-w N] [-t] [-e]
Part of FASTX Toolkit 0.0.14 by assafgordon@gmail.com

   [-h]         = This helpful help screen.
   [-i INFILE]  = FASTA/Q input file. default is STDIN.
   [-o OUTFILE] = FASTA/Q output file. default is STDOUT.
   [-w N]       = max. sequence line width for output FASTA file.
                  When ZERO (the default), sequence lines will NOT be wrapped -
                  all nucleotides of each sequences will appear on a single 
                  line (good for scripting).
   [-t]         = Output tabulated format (instead of FASTA format).
                  Sequence-Identifiers will be on first column,
                  Nucleotides will appear on second column (as single line).
   [-e]         = Output empty sequences (default is to discard them).
                  Empty sequences are ones who have only a sequence identifier,
                  but not actual nucleotides.

Input Example:
   >MY-ID
   AAAAAGGGGG
   CCCCCTTTTT
   AGCTN

Output example with unlimited line width [-w 0]:
   >MY-ID
   AAAAAGGGGGCCCCCTTTTTAGCTN

Output example with max. line width=7 [-w 7]:
   >MY-ID
   AAAAAGG
   GGGTTTT
   TCCCCCA
   GCTN

Output example with tabular output [-t]:
   MY-ID	AAAAAGGGGGCCCCCTTTTAGCTN

example of empty sequence:
(will be discarded unless [-e] is used)
  >REGULAR-SEQUENCE-1
  AAAGGGTTTCCC
  >EMPTY-SEQUENCE
  >REGULAR-SEQUENCE-2
  AAGTAGTAGTAGTAGT
  GTATTTTATAT

LGTM!

@martin-g
Copy link
Contributor Author

martin-g commented Feb 4, 2025

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Feb 4, 2025
@mencian mencian merged commit 63e105f into bioconda:master Feb 4, 2025
5 checks passed
@martin-g martin-g deleted the aarch64-fastx_toolkit-2 branch February 4, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants