This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
added a function to retrieve the environment type for a barcode #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s now displayed when a barcode get scanned
wasade
reviewed
Dec 1, 2016
knimin/lib/data_access.py
Outdated
| @@ -2422,3 +2425,61 @@ def _revert_ready(self, barcodes): | |||
| SET results_ready = NULL | |||
| WHERE barcode IN %s""" | |||
| self._con.execute(sql, [tuple(barcodes)]) | |||
|
|
|||
| def get_barcode_environment_types(self, barcode): | |||
| # TODO: write test code once test data have been dumped into DB! | |||
There was a problem hiding this comment.
would you prefer holding this pr until this is resolved?
There was a problem hiding this comment.
Depends on the timing of the DB dump. I don't want to wait for weeks with further development.
…ssen2/labadmin into display_barcode_environment Conflicts: knimin/lib/data_access.py knimin/lib/tests/test_data_access.py knimin/lib/tests/test_util.py knimin/tests/test_ag_pulldown.py knimin/tests/test_barcode_util.py
…play_barcode_environment
wasade
reviewed
Mar 31, 2017
knimin/lib/tests/test_data_access.py
Outdated
| @@ -358,7 +358,7 @@ def test_get_barcode_environment_types(self): | |||
|
|
|||
| # animal barcodes | |||
| barcode = '000002012' | |||
| exp = [u'Animal(Dog)'] | |||
| exp = [u'Human'] | |||
There was a problem hiding this comment.
the host for this sample changed...?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now displayed when a barcode get scanned. See issue #158