GUI #74

rnmitchell · 2024-05-17T19:22:32Z

Creating a GUI using streamlit. Code written by Shaheer Syed.

standage · 2024-05-23T21:24:02Z

I'm getting the following error, whether I run lusstr gui or streamlit run lusSTR/cli/gui.py.

$ lusstr gui

  You can now view your Streamlit app in your browser.

  Local URL: http://localhost:8501
  Network URL: http://192.168.101.24:8501

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'NSWindow should only be instantiated on the main thread!'
*** First throw call stack:
(
        0   CoreFoundation                      0x00007ff804a31dc6 __exceptionPreprocess + 242
        1   libobjc.A.dylib                     0x00007ff804521e9d objc_exception_throw + 48
        2   CoreFoundation                      0x00007ff804a5578c -[NSException raise] + 9
        3   AppKit                              0x00007ff808041b01 -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 1595
        4   AppKit                              0x00007ff8080414c0 -[NSWindow initWithContentRect:styleMask:backing:defer:] + 42
        5   libtk8.6.dylib                      0x000000011a288274 TkMacOSXMakeRealWindowExist + 740
        6   libtk8.6.dylib                      0x000000011a287dc2 TkWmMapWindow + 82
        7   libtk8.6.dylib                      0x000000011a1d7a21 MapFrame + 65
        8   libtcl8.6.dylib                     0x000000011a41e647 TclServiceIdle + 135
        9   libtcl8.6.dylib                     0x000000011a3fc2b1 Tcl_DoOneEvent + 385
        10  libtk8.6.dylib                      0x000000011a27775e TkpInit + 766
        11  libtk8.6.dylib                      0x000000011a1cf8ba Initialize + 2602
        12  _tkinter.cpython-311-darwin.so      0x0000000110e10738 Tcl_AppInit + 88
        13  _tkinter.cpython-311-darwin.so      0x0000000110e1044a Tkapp_New + 586
        14  _tkinter.cpython-311-darwin.so      0x0000000110e101ee _tkinter_create_impl + 222
        15  _tkinter.cpython-311-darwin.so      0x0000000110e0fe1b _tkinter_create + 187
        16  python3.11                          0x000000010f968143 cfunction_vectorcall_FASTCALL + 99
        17  python3.11                          0x000000010fa5ba44 _PyEval_EvalFrameDefault + 231956
        18  python3.11                          0x000000010f904898 _PyFunction_Vectorcall + 3064
        19  python3.11                          0x000000010f9065ca _PyObject_Call_Prepend + 186
        20  python3.11                          0x000000010f9986e9 slot_tp_init + 185
        21  python3.11                          0x000000010f98d6da type_call + 122
        22  python3.11                          0x000000010fa5c683 _PyEval_EvalFrameDefault + 235091
        23  python3.11                          0x000000010fa210d4 _PyEval_Vector + 2996
        24  python3.11                          0x000000010fa204a9 PyEval_EvalCode + 249
        25  python3.11                          0x000000010fa1b3ad builtin_exec + 381
        26  python3.11                          0x000000010f9680ad cfunction_vectorcall_FASTCALL_KEYWORDS + 93
        27  python3.11                          0x000000010fa5ba44 _PyEval_EvalFrameDefault + 231956
        28  python3.11                          0x000000010f904898 _PyFunction_Vectorcall + 3064
        29  python3.11                          0x000000010f909baa method_vectorcall + 458
        30  python3.11                          0x000000010fa62162 _PyEval_EvalFrameDefault + 258354
        31  python3.11                          0x000000010f904898 _PyFunction_Vectorcall + 3064
        32  python3.11                          0x000000010f909baa method_vectorcall + 458
        33  python3.11                          0x000000010fb57869 thread_run + 249
        34  python3.11                          0x000000010fae0704 pythread_wrapper + 36
        35  libsystem_pthread.dylib             0x00007ff8048e218b _pthread_start + 99
        36  libsystem_pthread.dylib             0x00007ff8048ddae3 thread_start + 15
)
libc++abi: terminating due to uncaught exception of type NSException

rnmitchell · 2024-05-23T21:47:21Z

That's the error I got too.

standage · 2024-05-24T12:56:46Z

Just pushed some changes to fix the issue, inspired by this thread. But now it looks like the menu needs troubleshooting.

rnmitchell · 2024-05-24T16:07:10Z

Yeah, now I'm getting that error when I open the file picker.

rnmitchell · 2024-05-28T13:37:04Z

I found this thread that may work, but I'm nervous to do any sudo code. 😬

standage · 2024-05-31T17:31:31Z

I was able to get the menu working by downgrading streamlit to version 1.32. Looks like this is a known issue with streamlit_option_menu: see victoryhb/streamlit-option-menu#70.

Now I've reproduced the file picker bug. Looking into it...

rnmitchell · 2024-07-01T16:55:54Z

@standage whenever you get a chance, please test the file/folder pickers to see if they are now working for you.

standage · 2024-07-02T13:44:42Z

@standage whenever you get a chance, please test the file/folder pickers to see if they are now working for you.

Just tested on some example data. Both the file picker and the entire workflow functioned as expected!

rnmitchell · 2024-07-02T14:43:54Z

I think this may be a good spot for merging. I plan to do some more work on the GUI, but I think it's a little bit more involved and wanted to get the basic version pushed to the master branch. The only issue I'm currently running into is the failing CI (which seems to be another tk issue??). Not too sure how to circumvent those errors.

standage

Looks good, works well on my end. As we discussed, we'll want to clean up the code as well as update the visual aesthetics of the app. But happy to merge for now.

standage · 2024-07-08T14:03:33Z

lusSTR/cli/gui.py

+def file_picker_dialog():
+    script_path = importlib.resources.files("lusSTR") / "scripts" / "file_selector.py"
+    result = subprocess.run(["python", script_path], capture_output=True, text=True)
+    if result.returncode == 0:
+        file_data = json.loads(result.stdout)
+        file_path = file_data.get("file_path")
+        if file_path:
+            return file_path
+        else:
+            st.error("No folder selected")
+    else:
+        st.error("Error selecting folder")


Clever trick!

standage · 2024-07-08T14:03:49Z

lusSTR/cli/gui.py

+import tkinter as tk
+from tkinter import filedialog
+
+
+
+# Create a global Tkinter root window
+try:
+    root = tk.Tk()
+    root.withdraw()  # Hide the root window
+except:
+    print("No GUI available!")


We can drop this code now, right?

This is what is allowing the GitHub CI to pass. Without it, it fails.

That's really surprising to me. The file_selector and folder_selector scripts that actually use tk don't touch this code.

It seemed to be hung up on the from lusSTR.cli import gui line from the cli/__init.py__ script.

I understand that having root = tk.Tk() in there without a try/except block will cause issues on CI. What I'm suggesting is that we shouldn't need tk anywhere in gui.py now, since that's all been moved to accessory scripts where tk can be run in the main thread.

Oooooooooh. Yes you are right!

rnmitchell · 2024-07-08T16:11:35Z

I think this is ready now.

adding gui code [skip ci]

0b60e8f

Fixing streamlit call

5e483cb

fixed bug in file/folder pickers

fa935dd

rnmitchell added 2 commits July 2, 2024 07:10

updating GUI settings [skip ci]

bed4277

updating GUI settings [skip ci]

c5ea072

rnmitchell added 2 commits July 2, 2024 10:29

updating GUI [skip ci]

edad9ea

updated README [skip ci]

05a9d7e

rnmitchell added 8 commits July 2, 2024 11:18

updated README and updated GUI [skip ci]

0977abd

changed GUI text

e90309c

troubleshooting CI issues

26d3c3f

troubleshooting CI issues again

d69ba46

troubleshooting CI issues again again

0a2c218

troubleshoot again again again

a12cfb0

troubleshoot again one last time

6f87808

pinning numpy version

7c93818

rnmitchell marked this pull request as ready for review July 3, 2024 16:35

rnmitchell requested a review from standage July 3, 2024 16:36

standage approved these changes Jul 8, 2024

View reviewed changes

rnmitchell and others added 3 commits July 8, 2024 10:28

merge master

8841806

Try removing tk from gui.py

d1efb70

formatted file

e7d5cb7

standage merged commit 3c2b19b into master Jul 8, 2024
2 checks passed

standage deleted the gui branch July 8, 2024 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GUI #74

GUI #74

rnmitchell commented May 17, 2024

standage commented May 23, 2024

rnmitchell commented May 23, 2024

standage commented May 24, 2024

rnmitchell commented May 24, 2024

rnmitchell commented May 28, 2024

standage commented May 31, 2024

rnmitchell commented Jul 1, 2024

standage commented Jul 2, 2024

rnmitchell commented Jul 2, 2024

standage left a comment

standage Jul 8, 2024

standage Jul 8, 2024

rnmitchell Jul 8, 2024 •

edited

Loading

standage Jul 8, 2024

rnmitchell Jul 8, 2024

standage Jul 8, 2024

rnmitchell Jul 8, 2024

rnmitchell commented Jul 8, 2024

GUI #74

GUI #74

Conversation

rnmitchell commented May 17, 2024

standage commented May 23, 2024

rnmitchell commented May 23, 2024

standage commented May 24, 2024

rnmitchell commented May 24, 2024

rnmitchell commented May 28, 2024

standage commented May 31, 2024

rnmitchell commented Jul 1, 2024

standage commented Jul 2, 2024

rnmitchell commented Jul 2, 2024

standage left a comment

Choose a reason for hiding this comment

standage Jul 8, 2024

Choose a reason for hiding this comment

standage Jul 8, 2024

Choose a reason for hiding this comment

rnmitchell Jul 8, 2024 • edited Loading

Choose a reason for hiding this comment

standage Jul 8, 2024

Choose a reason for hiding this comment

rnmitchell Jul 8, 2024

Choose a reason for hiding this comment

standage Jul 8, 2024

Choose a reason for hiding this comment

rnmitchell Jul 8, 2024

Choose a reason for hiding this comment

rnmitchell commented Jul 8, 2024

rnmitchell Jul 8, 2024 •

edited

Loading