Update GUI #80
Update GUI #80
Conversation
… edited output at once [skip ci]
|
This is ready for review @standage. I want to address the warning that lusSTR is throwing in the filter step, but it's proving to be a little bit more challenging than I thought, so figured this could be merged first since it's unrelated to the warning message. |
There was a problem hiding this comment.
Functional review was great. Thanks for the walkthrough the other day.
A lot of code changes appear to be related to autoformatting.
I have a couple questions and requests: see below.
The GUI code is a bit unwieldy in its current state, as we discussed. I'll take a crack at refactoring soon.
| profile = profile[profile.allele_type == "real_allele"] | ||
| profile = profile.query("allele_type == 'Typed'") | ||
| else: | ||
| profile = profile[profile.allele_type != "BelowAT"] | ||
| profile = profile.query("allele_type != ['BelowAT', 'Deleted']") |
There was a problem hiding this comment.
Did you make these changes to get rid of the pandas warnings? Because functionally, they look very similar.
I will say though, I was unaware that you could use list syntax in a query string! TIL
There was a problem hiding this comment.
No, I changed it to use a list since it needs to remove both BelowAT and Deleted sequences. I did it in line 149 just to be consistent in the code.
lusSTR/wrappers/filter.py
Outdated
| filtered_df = profile[profile.allele_type != "BelowAT"] | ||
| # filtered_df = profile.loc[([profile.allele_type != "BelowAT"]) & ([profile.allele_type != "Deleted"])] | ||
| filtered_df = profile.query("allele_type != ['BelowAT', 'Deleted']") |
There was a problem hiding this comment.
Please delete commented out code or fix.
Reformatting GUI and exploring interactive plots.