do not use std::string in the event handlers

biojppm · May 26, 2024 · 11d7bd2 · 11d7bd2
1 parent 0e9c853
commit 11d7bd2
Show file tree

Hide file tree

Showing 10 changed files with 512 additions and 179 deletions.
diff --git a/src/c4/yml/detail/stack.hpp b/src/c4/yml/detail/stack.hpp
@@ -25,7 +25,7 @@ namespace detail {
 template<class T, id_type N=16>
 class stack
 {
-    //static_assert(std::is_trivially_copyable<T>::value, "T must be trivially copyable");
+    static_assert(std::is_trivially_copyable<T>::value, "T must be trivially copyable");
     static_assert(std::is_trivially_destructible<T>::value, "T must be trivially destructible");
 
 public:

diff --git a/test/test_lib/test_engine.cpp b/test/test_lib/test_engine.cpp
@@ -72,8 +72,8 @@ void test_new_parser_events_from_yaml(ReferenceYaml const& yaml, std::string con
     ParseEngine<EventHandlerYamlStd> parser(&handler);
     std::string copy = yaml.parsed;
     parser.parse_in_place_ev("(testyaml)", to_substr(copy));
-    csubstr result = sink.get();
-    _c4dbgpf("~~~\n{}~~~\n", sink.get());
+    csubstr result = sink;
+    _c4dbgpf("~~~\n{}~~~\n", result);
     EXPECT_EQ(std::string(result.str, result.len), expected_events);
 }
 

diff --git a/test/test_lib/test_engine.hpp b/test/test_lib/test_engine.hpp
@@ -42,7 +42,7 @@ C4_NO_INLINE void test_new_parser_str_from_events(std::string const& expected_ev
     handler.reset();
     EventProducerFn<EventHandlerYamlStd> event_producer;
     event_producer(handler);
-    csubstr result = sink.get();
+    csubstr result = sink;
     _c4dbgpf("~~~\n{}~~~\n", result);
     EXPECT_EQ(std::string(result.str, result.len), expected_events);
 }
@@ -215,7 +215,7 @@ inline void _print_handler_info(EventHandlerYamlStd const& ps, csubstr stmt)
     };
     for(id_type i = 0; i < ps.m_stack.size(); ++i)
     {
-        auto const& str = ps._buf_(i).get();
+        csubstr const& str = ps._buf_(i);
         indent(i);
         _dbg_printf("[{}]\n", i);
         for(csubstr line : str.split('\n'))

diff --git a/test/test_suite.cpp b/test/test_suite.cpp
@@ -299,11 +299,11 @@ struct TestSequenceLevel
         if(prev)
             receive_src(*prev);
         _nfo_logf("level[{}]: parsing source:\n{}", level, src_evts);
-        evt_str_sink.reset();
+        evt_str_sink.clear();
         evt_handler_str_sink.reset();
         evt_handler_str_sink.m_stack.m_callbacks = get_callbacks();
         parser_str_sink.parse_in_place_ev(filename, to_substr(src_evts));
-        EXPECT_FALSE(evt_str_sink.get().empty());
+        EXPECT_NE(evt_str_sink.size(), 0);
         events_were_generated = true;
     }
 
@@ -655,7 +655,7 @@ struct TestSequenceData
         for(size_t i = 0; i < num; ++i)
         {
             levels[i].parse_yaml_to_events();
-            csubstr result = levels[i].evt_str_sink.get();
+            csubstr result = levels[i].evt_str_sink;
             events->compare_emitted_events_to_reference_events(std::string(result.str, result.len),
                                                                /*ignore_container_style*/false,
                                                                /*ignore_scalar_style*/(num>0));