Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ensure tests run with disabled exceptions #369

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented May 5, 2023

use longjmp() when exceptions are disabled
Fixes #359

@biojppm biojppm changed the title [fix] re #359: ensure tests run with disabled exceptions [fix] ensure tests run with disabled exceptions May 5, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 96.75%. Comparing base (507400e) to head (ee28e21).

❗ Current head ee28e21 differs from pull request most recent head 32e3bb9. Consider uploading reports for the commit 32e3bb9 to get more accurate results

Files Patch % Lines
src/c4/yml/detail/parser_dbg.hpp 33.33% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   96.73%   96.75%   +0.02%     
==========================================
  Files          22       22              
  Lines        8446     8448       +2     
==========================================
+ Hits         8170     8174       +4     
+ Misses        276      274       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/c4/yml/detail/parser_dbg.hpp Dismissed Show dismissed Hide dismissed
src/c4/yml/detail/parser_dbg.hpp Dismissed Show dismissed Hide dismissed
src/c4/yml/detail/parser_dbg.hpp Dismissed Show dismissed Hide dismissed
src/c4/yml/detail/parser_dbg.hpp Dismissed Show dismissed Hide dismissed
@biojppm biojppm force-pushed the fix/359-exceptions branch 4 times, most recently from cba730f to e4ecdbf Compare April 18, 2024 21:23
@biojppm biojppm merged commit 8dabbbc into master Apr 19, 2024
231 of 243 checks passed
@biojppm biojppm deleted the fix/359-exceptions branch April 19, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Even with the exceptions disabled there is still a throw happening
1 participant