Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for Python 3.12 #392

Merged
merged 3 commits into from
Nov 12, 2023
Merged

chore: Add support for Python 3.12 #392

merged 3 commits into from
Nov 12, 2023

Conversation

mboutet
Copy link
Contributor

@mboutet mboutet commented Nov 3, 2023

Really not sure that it's the only thing I need to do to support Python 3.12 😛

Fixes #391

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #392 (c9f3f53) into master (2cf09b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          22       22           
  Lines        8155     8155           
=======================================
  Hits         7877     7877           
  Misses        278      278           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@@ -245,7 +247,7 @@ jobs:
# use fetch-depth to ensure all tags are fetched
- {name: checkout, uses: actions/checkout@v3, with: {submodules: recursive, fetch-depth: 0}}
- name: create wheel
uses: joerick/cibuildwheel@v2.9.0
uses: pypa/cibuildwheel@v2.16.2
Copy link
Contributor Author

@mboutet mboutet Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/joerick/cibuildwheel was relocated to https://github.com/pypa/cibuildwheel and I also bumped to the latest version which adds support for Python 3.12.

@mboutet
Copy link
Contributor Author

mboutet commented Nov 10, 2023

@biojppm, sorry for the ping, but any chance you can approve the workflows so they can run?

@mboutet
Copy link
Contributor Author

mboutet commented Nov 12, 2023

I'm not sure if the failures in the CI are due to my changes. The failure for the samples workflow appears to be caused by the workflow trying to checkout commit c9f3f53 which is from my fork rather than your repository.

The following:

GIT_REPOSITORY https://github.com/biojppm/rapidyaml.git

should be updated to support cloning from the forked repository of a given PR.

@biojppm
Copy link
Owner

biojppm commented Nov 12, 2023

Thanks for your work!

@biojppm biojppm merged commit a5eefff into biojppm:master Nov 12, 2023
175 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Python 3.12
2 participants