[ENH] Numpy 2.0 compatibility #6850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
changed the title
ales-erjavec
force-pushed
the
numpy2.0
branch
from
2a40dcf to
2e7de0d
Compare
np.float_ -> np.float64 np.NaN -> np.nan np.ndarray.ptp -> np.ptp np.in1d -> np.isin np.row_stack -> np.vstack
This is the new preferred way:
https://numpy.org/devdocs/dev/depending_on_numpy.html#numpy-2-0-specific-advice
Numpy 2.0 changes scalar repr: https://numpy.org/neps/nep-0051-scalar-representation.html
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6850 +/- ##
==========================================
- Coverage 88.47% 88.36% -0.12%
==========================================
Files 332 332
Lines 73296 73296
==========================================
- Hits 64849 64765 -84
- Misses 8447 8531 +84 |
Catch all exceptions at import attempt.
ales-erjavec
force-pushed
the
numpy2.0
branch
from
2e7de0d to
e576461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Numpy 2.0 compatibility
Currently numpy 2.0 support is still missing in catboost (catboost/catboost#2671).
Description of changes
np.float_ -> np.float64
np.NaN -> np.nan
np.ndarray.ptp -> np.ptp
np.in1d -> np.isin
np.row_stack -> np.vstack
Replace oldest-supported-numpy with numpy>2.0 in the build dependencies. This is the new preferred way.
Remove catboost from requirements.
Includes