Skip to content

skip checks in Routes() #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2025
Merged

skip checks in Routes() #215

merged 5 commits into from
May 9, 2025

Conversation

adokter
Copy link
Contributor

@adokter adokter commented May 1, 2025

fix of issue #214, adding skip_checks and min_season_quality arguments to BirdFlowR::Routes()

@adokter adokter requested a review from ethanplunkett May 1, 2025 14:17
@adokter adokter self-assigned this May 1, 2025
@ethanplunkett
Copy link
Contributor

Rather than add these arguments to Routes() let's always use skip_checks = TRUE when calling lookup_species_metadata() from Routes(). Checking for quality when building a model feels important, but the Routes()` object isn't using the S&T data at all; it's just taking the species metadata.

@adokter adokter changed the title Add skip_checks argument to Routes() skip checks in Routes() May 6, 2025
@adokter
Copy link
Contributor Author

adokter commented May 6, 2025

@ethanplunkett made the change you suggested

@ethanplunkett ethanplunkett merged commit 054fc9c into main May 9, 2025
1 of 6 checks passed
@ethanplunkett ethanplunkett deleted the add_skip_checks_to_routes branch May 9, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants