fix: user meta is not a function error #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update prime-core package.json to resolving typing errors between @accounts/typeorm and typeorm which causes compilation to fail.
Resolve the user.meta is not a function error by making user.meta a static function which takes an id as an argument due to entities not inheriting their types methods.
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 73.52% 73.55% +0.02%
==========================================
Files 141 141
Lines 3162 3161 -1
Branches 507 507
==========================================
Hits 2325 2325
+ Misses 837 836 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
user.meta is not a functionerror that occurs when using the 0.4.0-beta.0 release of Prime.The error occurs due to the queried entities not receiving the methods of the entity type for some reason and is resolved by changing the function to a static method that takes a user's ID as an argument.
Solves: #411