Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nix flake to biscuit-cli #56

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Add Nix flake to biscuit-cli #56

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7adea1
Add Nix flake to biscuit-cli
er4hn Mar 16, 2024
7900292
Add Nix flake to biscuit-cli
er4hn Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 92 additions & 0 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
{
inputs = {
flake-utils.url = "github:numtide/flake-utils";
naersk.url = "github:nix-community/naersk";
nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
};

outputs = { self, flake-utils, naersk, nixpkgs }:
flake-utils.lib.eachDefaultSystem (system:
let
pkgs = (import nixpkgs) {
er4hn marked this conversation as resolved.
Show resolved Hide resolved
inherit system;
};

naersk' = pkgs.callPackage naersk {};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered using the overlay provided by naersk directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is that? I'm not super familiar with Nix and used the naersk template suggested by their github repo.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlays are a way to override packages definition (in a lazy recursive manner) but in that case they don't bring much. It would have let you extend the pkgs to include ones provided by naersk and have it available with pkgs.naersk.

In this case it doesn't matter and it's totally fine to stick to the official example.


in rec {
# For `nix build` & `nix run`:
defaultPackage = naersk'.buildPackage {
src = ./.;
};

# For `nix develop`:
devShell = pkgs.mkShell {
nativeBuildInputs = with pkgs; [
cargo
clippy
libiconv
rustc
rustfmt
rust-analyzer
];
};
Comment on lines +25 to +33
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have the same shell in both the flake and the classic shell.nix?

Note that one can pkgs.callPackage ./shell.nix in here if needed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question might more to the core contributors than yourself @er4hn :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't really use the shell.nix anymore, feel free to harmonize as needed.

}
);
}
Loading