Better display for errors::Logic

[divarvel]

authorization failed: an allow policy matched (policy index: 0), and the following checks failed: [Authorizer(FailedAuthorizerCheck { check_id: 0, rule: "check if right(\"efgh\")" }), Block(FailedBlockCheck { block_id: 1, check_id: 0, rule: "check if operation(\"read\")" })]

[divarvel]

i wanted to completely remove it, but it's still used. the strange thing is that it explicitly mentions block rules. Where is the error for authorizer rules with unbound variables in facts?

[divarvel]

after a bit of digging:

• unbound variables are checked by the parser when constructing rules, so all rules constructed by the parser will be checked, regardless of their origin, and the error will be a parser error, not a Logic error
• this error can indeed only happen when a block is added to the authorizer, so adding a broken rule to the authorizer will not be caught here (rules constructed by the parser will be ok, it can only happen for manually constructed rules)
• rules with unbound variables in head will not generate any fact (but not crash)

I think the ergonomics of this could be improved:

• by being clearer on invariants that Rule and friends should guarantee, no matter how they were constructed (this would be a bit of work because i think that we should do it in other places as well)
• for now, by calling validate_variables when adding rules to the authorizer, not only rules blocks

[Geal]

That makes sense, we should avoid those kinds of footguns

[codspeed-hq]

CodSpeed Performance Report

Merging #191 will not alter performance

_{Comparing better-display-for-logic-error (eb2a7c4) with v5 (6ad6f12)}

Summary

✅ 12 untouched benchmarks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.61%. Comparing base (6ad6f12) to head (eb2a7c4).
Report is 2 commits behind head on v5.

Additional details and impacted files

@@            Coverage Diff             @@
##               v5     #191      +/-   ##
==========================================
+ Coverage   65.57%   65.61%   +0.03%     
==========================================
  Files          27       27              
  Lines        6987     6994       +7     
==========================================
+ Hits         4582     4589       +7     
  Misses       2405     2405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.