remove previous_key from ThirdPartyBlockRequest #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #247 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5 #247 +/- ##
==========================================
+ Coverage 65.19% 65.57% +0.38%
==========================================
Files 27 27
Lines 6981 6987 +6
==========================================
+ Hits 4551 4582 +31
+ Misses 2430 2405 -25 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
divarvel
force-pushed
the
remove-previous-key-from-3rd-party-request
branch
from
8dada64 to
e3c320f
Compare
Same as for `legacyPublicKeys`, it is now deprecated and should not be set. It is kept in the schema to allow implementations to make sure it is not set.
this exposes a new public method on `Biscuit` and `UnverifiedBiscuit` to get a block’s version, same as printing a block contents or getting its external key. Exposing it on `UnverifiedBiscuit` will be useful for biscuit-cli
divarvel
force-pushed
the
remove-previous-key-from-3rd-party-request
branch
from
d5f7b63 to
6ad363f
Compare
Geal
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as for
legacyPublicKeys, it is now deprecated and should not be set. It is kept in the schema to allow implementations to make sure it is not set.